问题描述
我是C语言的初学者,我得到的其中一项任务是写井字游戏。我正在运行游戏,但是每次您将X放在O位置时(反之亦然),它都会覆盖它。我也很欣赏关于优化代码的评论,因为我是一个初学者,并不了解很多概念。谢谢!这是我到目前为止所得到的
#include<stdio.h>
void redrawBoard(char array[]);
void markBoard (int x,int o,char array[]);
int checkForWin(char array[]);
int checkForWin(char array[])
{
int a;
char x = 'X';
char o = 'O';
if (array[0] == x && array[4] == x && array[8] == x) // winning cases for x
return 1;
if (array[2] == x && array[4] == x && array[6] == x)
return 1;
if (array[0] == x && array[1] == x && array[2] == x)
return 1;
if (array[3] == x && array[4] == x && array[5] == x)
return 1;
if (array[6] == x && array[7] == x && array[8] == x)
return 1;
if (array[0] == x && array[3] == x && array[6] == x)
return 1;
if (array[1] == x && array[4] == x && array[7] == x)
return 1;
if (array[2] == x && array[5] == x && array[8] == x)
return 1;
if (array[1] == x && array[4] == x && array[6] == x && array[8] ==x) //checking for draw with x combinations 1st pattern
return 3;
if (array[0] == x && array[2] == x && array[4] == x && array[7] ==x)
return 3;
if (array[0] == x && array[4] == x && array[5] == x && array[6] ==x)
return 3;
if (array[2] == x && array[3] == x && array[4] == x && array[8] ==x)
return 3;
if (array[1] == x && array[4] == x && array[5] == x && array[6] ==x) //checking for draw with x combinations 2nd pattern
return 3;
if (array[0] == x && array[4] == x && array[5] == x && array[7] ==x)
return 3;
if (array[2] == x && array[3] == x && array[4] == x && array[7] ==x)
return 3;
if (array[1] == x && array[3] == x && array[4] == x && array[8] ==x)
return 3;
if (array[0] == o && array[4] == o && array[8] == o) //// winning cases for o
return 2;
if (array[2] == o && array[4] == o && array[6] == o)
return 2;
if (array[0] == o && array[1] == o && array[2] == o)
return 2;
if (array[3] == o && array[4] == o && array[5] == o)
return 2;
if (array[6] == o && array[7] == o && array[8] == o)
return 2;
if (array[0] == o && array[3] == o && array[6] == o)
return 2;
if (array[1] == o && array[4] == o && array[7] == o)
return 2;
if (array[2] == o && array[5] == o && array[8] == o)
return 2;
if (array[1] == o && array[4] == o && array[6] == o && array[8] == o) //checking for draw with o combinations 1st pattern
return 3;
if (array[0] == o && array[2] == o && array[4] == o && array[7] == o)
return 3;
if (array[0] == o && array[4] == o && array[5] == o && array[6] == o)
return 3;
if (array[2] == o && array[3] == o && array[4] == o && array[8] == o)
return 3;
if (array[1] == o && array[4] == o && array[5] == o && array[6] == o) //checking for draw with o combinations 2nd pattern
return 3;
if (array[0] == o && array[4] == o && array[5] == o && array[7] == o)
return 3;
if (array[2] == o && array[3] == o && array[4] == o && array[7] == o)
return 3;
if (array[1] == o && array[3] == o && array[4] == o && array[8] == o)
return 3;
else
return 0;
return(a);
}
void markBoard (int x,char array[])
{
int i = 0;
char j = 'X';
char k = 'O';
while( x >= 1 && x <= 9)
{
array[x - 1] = j;
redrawBoard(array);
break;
}
while (o >= 1 && o <= 9)
{
array[o - 1] = k;
redrawBoard(array);
break;
}
}
void redrawBoard(char array[])
{
printf(" Player 1 is X; Player 2 is O;\n\n");
printf(" | | \n");
printf(" %c | %c | %c \n",array[0],array[1],array[2]);
printf(" ______|______|______ \n");
printf(" | | \n");
printf(" %c | %c | %c \n",array[3],array[4],array[5]);
printf(" ______|______|______ \n");
printf(" | | \n");
printf(" %c | %c | %c \n",array[6],array[7],array[8]);
printf(" | | \n");
}
int main()
{
int x;
int o;
char array[9] = {'1','2','3','4','5','6','7','8','9'};
printf("tic tac toe game\n");
redrawBoard(array);
while (checkForWin(array) == 0)
{
printf("P1 start \n");
scanf("%d",&x);
markBoard(x,o,array);
printf("P2 go on\n");
scanf("%d",&o);
markBoard(x,array);
}
if (checkForWin(array) == 1)
printf("P1 won\n");
if (checkForWin(array) == 2)
printf("P2 won\n");
if (checkForWin(array) == 3)
printf("draw \n");
return 0;
}
解决方法
-
您提到的问题是,在此单元格中已经有一个值时,您没有测试。
-
关于优化:
-
避免大量使用
if cases
!考虑更好的检查以检查谁是赢家。 例如,查看此检查:char winnerIs(char** Board,int i,int j) { if (Board[i][j] == Board[i][(j+1)%3] && Board[i][j] == Board[i][(j+2)%3]) { // got a column return Board[i][j]; } else if (Board[i][j] == Board[(i+1)%3][j] && Board[i][j] == Board[(i+2)%3][j]) { // got a row return Board[i][j]; } else if (i == j && Board[i][j] == Board[(i+1)%3][(j+1)%3] && Board[i][j] == Board[(i+2)%3][(j+2)%3]) { // got the forward diagonal return Board[i][j]; } else if (i+j == 2 && Board[i][j] == Board[(i+2)%3][(j+1)%3] && Board[i][j] == Board[(i+1)%3][(j+2)%3]) { // got the reverse diagonal return Board[i][j]; } else { // got nothing return 0; }
-
避免大量打印!最好为游戏使用一种结构,例如棋盘-如果您想使用动态游戏,则为
char board[][]
或更好的char** Board
。并打印整个board
一次。 -
代替下一个代码:
printf("P1 start \n"); scanf("%d",&x); markBoard(x,o,array); printf("P2 go on\n"); scanf("%d",&o); markBoard(x,array);
进行如下操作:
int player = 1;
char row,col;
player = (player % 2) ? 1 : 2;
scanf("%c %c",&row,&col);
markBoard(row,col,board);
就像您不需要重复相同的代码一样,它会自动知道每个回合,现在轮到谁了。
-
代替下一个代码:
if (checkForWin(array) == 1) printf("P1 won\n"); if (checkForWin(array) == 2) printf("P2 won\n"); if (checkForWin(array) == 3) printf("draw \n");
连接一些条件,例如:
if (checkForWin(array) == 1 || checkForWin(array) == 2) {
printf("Congratulations %c!\n",winner);
} else {
printf("Game ends in a draw.\n");
}
-
要制作更多的“美人”代码,您可以添加一个结构来管理整个游戏,例如:
typedef struct { int size; int **board; // the board /* scores of all options */ int *rowScores; int *colScores; int topLeftBottomRightDiagonalScores; int topRightBottomLeftDiagonalScores; } Game; typedef struct { // position on the board int x; int y; } Position;
-
您的
void markBoard (int x,int o,char array[])
函数进行了大量迭代以印刷整个电路板。最好一次创建整个董事会,然后在整个董事会上运行。