问题描述
所以我尝试制作一个过滤系统，当警告小于3时，它可以正常工作直到达到4，这意味着（禁止时间）它会触发静音。这是代码
@commands.Cog.listener()
async def on_message(self,message):
if not message.author.bot:
if not message.author.guild_permissions.manage_messages:
for b in ignored:
if b in message.content.lower():
return
else:
self.cur.execute(f"SELECT text FROM badwords WHERE guild_id = {message.guild.id}")
result = self.cur.fetchall()
bword = [x[0] for x in result]
if any(b in bword for b in message.content.lower().split(" ")):
self.cur.execute(f"SELECT onoff from mutedet WHERE guild_id = {message.guild.id}")
result3 = self.cur.fetchone()
if result3 is not None:
self.cur.execute(f"SELECT role FROM mute WHERE guild_id = {message.guild.id}")
mutedet = self.cur.fetchone()
if mutedet is not None:
self.cur.execute(f"SELECT warn FROM warning WHERE guild_id = {message.guild.id} and user_id = {message.author.id}")
result2 = self.cur.fetchone()
if result2 is None:
role = discord.utils.get(message.author.guild.roles,id=int(mutedet[0]))
sql = f"INSERT INTO warning(guild_id,user_id,warn) VALUES(?,?,?)"
val = (message.guild.id,message.author.id,1)
self.cur.execute(sql,val)
self.db.commit()
await message.channel.purge(limit=1)
await message.author.send(f"hey {message.author.mention} you are muted for 10 Minutes,keep doing this will result on getting banned.")
await message.channel.send(f"hey {message.author.mention},That word isn't allowed here!")
await message.author.add_roles(role)
await asyncio.sleep(600)
await message.author.remove_roles(role)
await message.author.send("You are unmuted,If you keep doing this you'll be banned!")
elif result2 is not None:
self.cur.execute(f"SELECT warn FROM warning WHERE guild_id = {message.guild.id} and user_id = {message.author.id}")
warnamount = self.cur.fetchone()
role = discord.utils.get(message.author.guild.roles,id=int(mutedet[0]))
wcount = int(warnamount[0])
if wcount >= 3:
self.cur.execute(f"DELETE FROM warning WHERE guild_id = {message.guild.id} and user_id = {message.author.id}")
self.db.commit()
await message.author.send("You have been banned,because of 3 Violates in a row!")
await message.author.ban(reason="3 Violates in a row!")
else:
self.cur.execute(f"SELECT warn FROM warning WHERE guild_id = {message.guild.id} and user_id = {message.author.id}")
warnings = self.cur.fetchone()
warns = int(warnings[0])
sql = f"UPDATE warning SET warn = ? WHERE guild_id = ? and user_id = ?"
val = (warns + 1,message.guild.id,message.author.id)
self.cur.execute(sql,val)
self.db.commit()
await message.channel.purge(limit=1)
await message.author.send(f"hey {message.author.mention} you are muted for 10 Minutes,keep doing this will result on getting banned.")
await message.channel.send(f"hey {message.author.mention},That word isn't allowed here!")
await message.author.add_roles(role)
await asyncio.sleep(600)
await message.author.remove_roles(role)
await message.author.send("You are unmuted,If you keep doing this you'll be banned!")
禁止消息作者后，它又以某种方式再次添加到db中：/ 有更好的代码逻辑建议吗？
解决方法
该函数非常大，您应该将其折射为更小，更抽象的版本。 就像我认为您正在测试包含不良词的消息一样，您可以为其创建一个函数来检查不良词并返回true或false。 您可以将数据库操作包装在函数中，这将更有意义，更容易编写和进行推理。
将数据库逻辑与代码分开，将其包装到函数中
再次使消息静音的原因是，当消息达到3后，您将删除警告，并且当他向用户发回警告消息时，消息已被删除，结果2再次为“无”，并且此循环继续。
一种可能的解决方案是使用一个表，其中包含被禁止的成员，一旦超过警告，您就可以将该用户放到该表中。