问题描述
在Veracode中扫描应用程序时,我们遇到了安全威胁问题。获得了“系统或配置设置的外部控制(CWE ID 15)”。
报告扫描 using (var connection = new SqlConnection(connectionString))
我们正在通过传递连接字符串来检查“ SQLConnectionExists” ,
string sqlConnString = SqlHelper.GetSQLConnectionString(input.ServerName,dbName,isWinAuth,input.UserName,input.Password);
if (!DBUtil.CheckSQLConnectionExists(sqlConnString))
{
_ValidationMessage += "Database Unreachable \n";
isValid = false;
}
public static bool CheckSQLConnectionExists(string connectionString)
{
bool isExist = false;
try
{
using (var connection = new SqlConnection(connectionString))
{
connection.Open();
connection.Close();
isExist = true;
}
}
catch (Exception ex)
{
Logger.Instance.Log(LogLevel.EXCEPTION,"CheckSQLConnectionExists Exception : " + ex.Message);
}
return isExist;
}
public static string GetSQLConnectionString(string servername,string db,bool isWinAuth,string username,string password)
{
System.Data.SqlClient.SqlConnectionStringBuilder builder = new System.Data.SqlClient.SqlConnectionStringBuilder();
builder["Data Source"] = servername;
builder["Initial Catalog"] = db;
if (isWinAuth)
{
builder["Integrated Security"] = "SSPI";
builder["Trusted_Connection"] = "Yes";
}
else
{
builder["Persist Security Info"] = false;
builder["User ID"] = username;
builder["Password"] = password;
}
return builder.ConnectionString;
}
在这一行using (var connection = new SqlConnection(connectionString))
中,我们在安全扫描中遇到了错误。您能否请一些提供解决此Veracode错误的建议。
解决方法
Veracode检测到input.ServerName,input.UserName和input.Password由用户控制,这是一种风险。
确保实施验证-如果可能,将其与白名单或已知的预定义服务器名称进行比较。另外,检查输入的(注入的)“最小池大小”是否大于预期值。使用框架类,例如使用SqlConnectionStringBuilder的框架类
随后建议将此检查作为mitigation。