Laravel查询构建器在使用orWhere条件时无法按预期工作

问题描述

我想将sql查询转换为laravel

我的sql查询工作正常并且仅显示active_state = 1记录，但是laravel查询qhows也使不活动的行。我做错了

select a.id,a.assigned_user_name,a.meeting_start_date,a.call_start_date
from mgl_report_targets as a 
  left join dcalendardate b on b.datevalue=a.meeting_start_date 
  left join dcalendardate c on c.datevalue=a.call_start_date  
where (b.datevalue > '2020-07-31' and b.datevalue < '2020-09-01')
  or ( c.datevalue > '2020-07-31' and c.datevalue < '2020-09-01') 
  and a.active_status='1'

我尝试过

$report_details=DB::table('mgl_report_targets');
$report_details=$report_details->leftjoin('dcalendardate as a','a.datevalue','=',DB::raw("mgl_report_targets.meeting_start_date::date")); 
$report_details=$report_details->leftjoin('dcalendardate as b','b.datevalue',DB::raw("mgl_report_targets.call_start_date::date"));
$report_details=$report_details->where('a.datevalue','>','2020-07-31');
$report_details=$report_details->where('a.datevalue','<','2020-09-01');
$report_details=$report_details->orWhere('b.datevalue','2020-07-31');
$report_details=$report_details->orWhere('b.datevalue','2020-09-01');
$report_details=$report_details->where('mgl_report_targets.active_status','1');
$report_details=$report_details->select('mgl_report_targets.id','mgl_report_targets.assigned_user_name','mgl_report_targets.meeting_start_date','mgl_report_targets.call_start_date')
->get();

解决方法

您缺少的是()包装或条件。通过使用orWhere，雄辩者只会创建一个OR条件，而不会将其包装在括号中。您需要使用回调：

$report_details=DB::table('mgl_report_targets')
   ->leftjoin('dcalendardate as a','a.datevalue','=',DB::raw("mgl_report_targets.meeting_start_date::date"))
   ->leftjoin('dcalendardate as b','b.datevalue',DB::raw("mgl_report_targets.call_start_date::date"))
   ->where(function ($query) { // <-- here you create the first '()`
      return $query->where('a.datevalue','>','2020-07-31')
        ->where('a.datevalue','<','2020-09-01');
   })
   ->orWhere(function ($query) { // <-- here you create the second '()`
      return $query->where('b.datevalue','2020-07-31')
        ->where('b.datevalue','2020-09-01');
   })
   ->where('mgl_report_targets.active_status','1')
   ->select('mgl_report_targets.id','mgl_report_targets.assigned_user_name','mgl_report_targets.meeting_start_date','mgl_report_targets.call_start_date')

这将创建以下查询：

select `mgl_report_targets`.`id`,`mgl_report_targets`.`assigned_user_name`,`mgl_report_targets`.`meeting_start_date`,`mgl_report_targets`.`call_start_date` 
from `mgl_report_targets` 
  left join `dcalendardate` as `a` on `a`.`datevalue` = mgl_report_targets.meeting_start_date::date 
  left join `dcalendardate` as `b` on `b`.`datevalue` = mgl_report_targets.call_start_date::date 
where (`a`.`datevalue` > ? and `a`.`datevalue` < ?) 
  or (`b`.`datevalue` > ? and `b`.`datevalue` < ?) 
  and `mgl_report_targets`.`active_status` = ?

对我来说，这似乎等同于您的查询

---

为了更好地调试查询，可以使用dd()命令来打印正在运行的实际sql：

// Instead of
$report_details->get();

// use
$report_details->dd();

参考：https://laravel.com/docs/5.8/queries#debugging