if / ifelse逻辑的效率

问题描述

|| 我想知道是否有一种更有效的方法来编写以下内容，因为第一组URL都具有相同的结果。提前致谢。

    <?PHP 
if (stripos($_SERVER[\'REQUEST_URI\'],\'/feet-foxes/\') !== false) {
    echo \'\';
}
elseif (stripos($_SERVER[\'REQUEST_URI\'],\'/aerial-immersion/\') !== false) {
    echo \'\';
}
elseif (stripos($_SERVER[\'REQUEST_URI\'],\'/taste-paper-air/\') !== false) {
    echo \'\';
}
elseif (stripos($_SERVER[\'REQUEST_URI\'],\'/dance-movement-therapy-group/\') !== false) {
    echo \'\';
}
elseif (stripos($_SERVER[\'REQUEST_URI\'],\'/fencing-fun/\') !== false) {
    echo \'\';
}
elseif ($ticketlink = get_post_meta($post->ID,\'Ticket-Link-1\',true)) {
    echo \'<div class=\"artist-buy-tickets-Box\"><a class=\"artist-buy-button\" href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
}
else { 
    echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
}
?>

    

解决方法

        我非常确定您的效率标准是什么，但这是一个更好的选择。对于匿名函数，它要求PHP> = 5.3（可以在较早的版本中完成，但是使用

create_function

有点麻烦）。

$urlPaths = array(
    \'/fencing-fun/\',\'/dance-movement-therapy-group/\',\'/taste-paper-air/\',\'/aerial-immersion/\',\'/feet-foxes/\',);

if (!empty(array_filter($urlPaths,function($item) {
                            return stripos($_SERVER[\'REQUEST_URI\'],$item) !== false;
                        }))
{
    echo \'\';
}

我对残酷的缩进表示歉意-我想出的任何丑陋的东西都无法提出。     ,        呼叫“ 3”比呼叫“ 4”的价格很便宜，因此首先这样做。为了（微）优化，让具有相同结果的五个测试成为一个表达式：

<?php 
if (stripos($_SERVER[\'REQUEST_URI\'],\'/feet-foxes/\') !== false
        || stripos($_SERVER[\'REQUEST_URI\'],\'/aerial-immersion/\') !== false
        || stripos($_SERVER[\'REQUEST_URI\'],\'/taste-paper-air/\') !== false
        || stripos($_SERVER[\'REQUEST_URI\'],\'/dance-movement-therapy-group/\') !== false
        || stripos($_SERVER[\'REQUEST_URI\'],\'/fencing-fun/\') !== false) {
    echo \'\';
} elseif ($ticketlink = get_post_meta($post->ID,\'Ticket-Link-1\',true)) {
    echo \'<div class=\"artist-buy-tickets-box\"><a class=\"artist-buy-button\" href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
} else { 
    echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
}
?>

这样就消除了重复代码（

echo \'\';

）的需要。您可以对测试进行排序，以使最频繁的URI首先出现，以便利用短路评估（不过，我怀疑这严格来说是理论上的）。     ,        

$needles = array(\'/feet-foxes/\',\'etc\');
$found = false;
foreach($needles as $needle){
    if (stripos($_SERVER[\'REQUEST_URI\'],$needle) !== false){
        $found = true;
        break;
    }
}
if(!$found){
    if ($ticketlink = get_post_meta($post->ID,true)) {
        echo \'<div class=\"artist-buy-tickets-box\"><a class=\"artist-buy-button\"   href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
    }
    else { 
        echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
    }
}

您确定要在if中分配某些内容吗？     ,        重写如下。这样，轻松地将更多具有相同结果的URL添加到该组。

$echo = null;

$paths = array(
    \'feet-foxes\',\'aerial-immersion\',\'taste-paper-air\',\'dance-movement-therapy-group\',\'fencing-fun\'
);

foreach ( $paths as $path ) {
    if ( stripos($_SERVER[\'REQUEST_URI\'],\'/\'.$path.\'/\') !== false ) {
        $echo = \'\';
        break;
    }
}

if ( !is_null($echo) ) {
    echo \'\';
} else if ( $ticketlink = get_post_meta($post->ID,true) ) {
    echo \'<div class=\"artist-buy-tickets-box\"><a class=\"artist-buy-button\" href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
} else { 
    echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
}

    ,        

if (!preg_match(\'#/(feet-foxes|aerial-immersion|taste-paper-air|dance-movement-therapy-group|fencing-fun)/#\',$_SERVER[\'REQUEST_URI\'])) {
    if ($ticketlink = get_post_meta($post->ID,true)) {
        echo \'<div class=\"artist-buy-tickets-box\"><a class=\"artist-buy-button\" href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
    }
    else { 
        echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
    }
}

    ,        如果采取相同的措施，只需将它们全部集中到一个条件中即可。但是，您似乎什么也没做，因此不需要上一节吗？

<?php 
if (stripos($_SERVER[\'REQUEST_URI\'],\'/feet-foxes/\') !== false || 
    stripos($_SERVER[\'REQUEST_URI\'],\'/aerial-immersion/\') !== false ||
    stripos($_SERVER[\'REQUEST_URI\'],\'/taste-paper-air/\') !== false ||
    stripos($_SERVER[\'REQUEST_URI\'],\'/dance-movement-therapy-group/\') !== false ||
    stripos($_SERVER[\'REQUEST_URI\'],\'/fencing-fun/\') !== false
    ) {
    // If you\'re actually doing nothing - this whole section isn\'t needed?
    echo \'\';
}
elseif ($ticketlink = get_post_meta($post->ID,true)) {
    echo \'<div class=\"artist-buy-tickets-box\"><a class=\"artist-buy-button\" href=\"\'.$ticketlink.\'\" title=\"Buy tickets\" target=\"_blank\">Buy Tickets</a>\';
}
else { 
    echo \'<h6>TICKETS ON SALE<br/>JUNE 15 2011</h6>\';
}
?>